Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update register_sequence_parallel_allreduce_hooks #9782

Merged
merged 9 commits into from
Jan 15, 2025

Conversation

DesmonDay
Copy link
Contributor

PR types

Others

PR changes

Others

Description

Update register_sequence_parallel_allreduce_hooks

Copy link

paddle-bot bot commented Jan 14, 2025

Thanks for your contribution!

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (4bdb06c) to head (4bae02d).
Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
paddlenlp/peft/lora/loraga_utils.py 0.00% 6 Missing ⚠️
paddlenlp/trainer/trainer.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #9782      +/-   ##
===========================================
+ Coverage    52.15%   52.37%   +0.21%     
===========================================
  Files          732      730       -2     
  Lines       116371   115262    -1109     
===========================================
- Hits         60695    60363     -332     
+ Misses       55676    54899     -777     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@ZHUI ZHUI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZHUI ZHUI merged commit 8fb109a into PaddlePaddle:develop Jan 15, 2025
8 of 12 checks passed
@DesmonDay DesmonDay deleted the fix_seq branch January 15, 2025 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants