替换Pillow为最新版 #10386
Closed
替换Pillow为最新版 #10386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
解决多次识别pdf，受第一次页面最大数量影响的bug
## 替换Pillow为最新版 主要是更新FreeTypeFont.getsize 为 getbbox
## 替换Pillow为最新版 主要是更新FreeTypeFont.getsize 为 getbbox
## 替换Pillow为最新版 主要是更新FreeTypeFont.getsize 为 getbbox
## 替换Pillow为最新版 主要是更新FreeTypeFont.getsize 为 getbbox
|
Thanks for your contribution! |
shiyutang
requested changes
Jul 14, 2023
There was a problem hiding this comment.
- getsize替换逻辑不太正确。
- 需要去除ppocr 的requirements中对于pillow版本的依赖。
- 同步提交PR到dygraph分支。
- 另外下面的两行也可以替换一下：
ppocr/data/imaug/rec_img_aug.py L403: Image.ANTIALIAS-> Image.LANCZOS
tools/infer/predict_rec.py L403: Image.ANTIALIAS-> Image.LANCZOS
refer: https://pillow.readthedocs.io/en/stable/releasenotes/2.7.0.html#antialias-renamed-to-lanczos
| @@ -23,7 +23,7 @@ def load_fonts(self, fonts_config): | |||
|
|
|||
| def get_valid_height(self, font_path): | |||
| font = ImageFont.truetype(font_path, self.height - 4) | |||
| _, font_height = font.getsize(self.char_list) | |||
| _ , _ , _ , font_height = font.getbbox(self.char_list) | |||
There was a problem hiding this comment.
previous:
width, height = font.getsize("Hello world")
Now:
left, top, right, bottom = font.getbbox("Hello world")
width, height = right - left, bottom - top
refer:
https://pillow.readthedocs.io/en/stable/releasenotes/9.2.0.html#font-size-and-offset-methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10344
替换Pillow为最新版
主要是更新FreeTypeFont.getsize 为 getbbox