Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed bug with "max_text_length" for VisionLAN #11025

Merged
merged 1 commit into from
Oct 12, 2023
Merged

Fixed bug with "max_text_length" for VisionLAN #11025

merged 1 commit into from
Oct 12, 2023

Conversation

victor30608
Copy link
Contributor

@victor30608 victor30608 commented Sep 28, 2023 •
edited by shiyutang
Loading

cherry-pick of #10962

This PR helps pass the max_text_length through args during infer_rec

@paddle-bot
Copy link

paddle-bot bot commented Sep 28, 2023

Thanks for your contribution!

@victor30608 victor30608 changed the base branch from dygraph to release/2.7 September 28, 2023 16:13
@victor30608 victor30608 changed the base branch from release/2.7 to dygraph September 28, 2023 16:17
@victor30608
Copy link
Contributor Author

victor30608 commented Oct 9, 2023 •
edited
Loading

@shiyutang I did something wrong?

@shiyutang
Copy link
Collaborator

no, the CI has its own problem, we will fix it soon ~

@victor30608
Copy link
Contributor Author

no, the CI has its own problem, we will fix it soon ~

Can u approve my PR ?

shiyutang
shiyutang approved these changes Oct 12, 2023
View reviewed changes
Copy link
Collaborator

@shiyutang shiyutang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shiyutang shiyutang merged commit d0d77fe into PaddlePaddle:dygraph Oct 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shiyutang shiyutang shiyutang approved these changes

@andyjiang1116 andyjiang1116 Awaiting requested review from andyjiang1116

Assignees

@Sunting78 Sunting78

Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@victor30608 @shiyutang @Sunting78