【OCR Issue No.9】以可选形式支持Visualdl #11947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! |
GreatV
reviewed
Apr 16, 2024
ppocr/utils/loggers/vdl_logger.py
Outdated
| except ImportError: | ||
| raise ImportError( | ||
| "Please install visualdl via `pip install visualdl` or " | ||
| "`pip install paddleocr[visualdl]`." |
There was a problem hiding this comment.
emmm？汪师傅是觉得不要visualdl比较好吗？
There was a problem hiding this comment.
不要 pip install paddleocr[visualdl]
setup.py
Outdated
| @@ -49,6 +49,9 @@ def readme(): | |||
| entry_points={"console_scripts": ["paddleocr= paddleocr.paddleocr:main"]}, | |||
| version=VERSION, | |||
| install_requires=load_requirements(['requirements.txt', 'ppstructure/recovery/requirements.txt']), | |||
| extra_requires={ | |||
| 'visualdl': ['visualdl'], | |||
|
这个ci又因为clone不下来挂了，我们得想办法把ci迁到github action上。 |
|
这个ci的脚本好像不在仓库里 |
这个 CI，是在 GPU 环境里直接跑模型； 我觉得其实没有太大的必要，能有完整的单测，在 CPU 上跑，应该就足够了。但是，看起来， 好像并没什么单测。。。 这个仓库的设计，以后或许可以多借鉴一下 pytorch/vision 。 |
|
@GreatV @Liyulingyue 其实我觉得我们应该做的彻底一些：完全去掉 visualdl。
benchmark 路径下，对 visualdl 的使用，我还不太清楚其必要性，但觉得也可以先移除。 |
|
这个CI和脚本感觉对不上 |
@JiaXiao243 能在这里解释一下现在的 CI 的情况吗？ |
# Conflicts: # ppocr/utils/loggers/vdl_logger.py # tools/program.py
|
benchmark/PaddleOCR_DBNet 这个目录我还不知道是干啥的，不过，我先合入吧。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11906 task9
#11924