Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update FAQ.md, delete repeated question #11972

Merged
merged 6 commits into from
Apr 22, 2024
Merged

Conversation

xu8117
Copy link
Contributor

@xu8117 xu8117 commented Apr 19, 2024

No description provided.

Copy link

paddle-bot bot commented Apr 19, 2024

Thanks for your contribution!

@CLAassistant
Copy link

CLAassistant commented Apr 19, 2024

CLA assistant check
All committers have signed the CLA.

@GreatV GreatV self-requested a review April 21, 2024 00:46
Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you check the English documentation and change the description accordingly as well.

Comment on lines 173 to 176
#### Q: 如何识别招牌或者广告图中的艺术字?

A: 招牌或者广告图中的艺术字是文本识别一个非常有挑战性的难题,因为艺术字中的单字和印刷体相比,变化非常大。如果需要识别的艺术字是在一个词典列表内,可以将改每个词典认为是一个待识别图像模板,通过通用图像检索识别系统解决识别问题。可以尝试使用PaddleClas的图像识别系统。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to delete the following paragraph

Q: 如何识别招牌或者广告图中的艺术字?
A: 招牌或者广告图中的艺术字是文本识别一个非常有挑战性的难题,因为艺术字中的单字和印刷体相比,变化非常大。如果需要识别的艺术字是在一个词典列表内,可以将该每个词典认为是一个待识别图像模板,通过通用图像检索识别系统解决识别问题。可以尝试使用PaddleClas的图像识别系统PP-shituV2。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the second be deleted and the first retained?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xu8117, yes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GreatV I'm done with the doc. Anything else I need to change. And git commit log is a bit messy, do I need to re-commit a pr

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xu8117, no need re-commit.

@GreatV
Copy link
Collaborator

GreatV commented Apr 22, 2024

hi @xu8117, You need to pass CI, that is, run pre-commit to fix the codestyle problem (in this case the problem is missing blank lines).

image

@PaddlePaddle PaddlePaddle locked and limited conversation to collaborators Apr 22, 2024
@PaddlePaddle PaddlePaddle unlocked this conversation Apr 22, 2024
Copy link
Collaborator

@GreatV GreatV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GreatV GreatV merged commit 00f0d42 into PaddlePaddle:main Apr 22, 2024
2 of 3 checks passed
@xu8117 xu8117 deleted the patch-1 branch April 22, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants