-
Notifications
You must be signed in to change notification settings - Fork 7.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
openocr compti code #12033
openocr compti code #12033
Conversation
Thanks for your contribution! |
@@ -55,7 +55,7 @@ def forward(self, predicts, batch): | |||
) | |||
elif name == "NRTRLoss": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个改动会影响其他的算法吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
没有影响,同时修复ppocrv4识别蒸馏的bug
ppocr/modeling/backbones/__init__.py
Outdated
@@ -25,6 +25,7 @@ def build_backbone(config, model_type): | |||
from .rec_lcnetv3 import PPLCNetV3 | |||
from .rec_hgnet import PPHGNet_small | |||
from .rec_vit import ViT | |||
from .rec_repvit import repvit_svtr_det |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
命名的规范上可否与之前统一呢?比如bacbone是否有特定的名称?一个小建议,可以再注意下python大小写字母的类命名规范
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
@@ -0,0 +1,169 @@ | |||
Global: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
配置文件如果都是同一个算法,但是进行大小模型蒸馏,我觉得可以统一放在一个文件夹目录下。比如之前的configd/det/ch_PP-OCRv4/ 把大小模型和蒸馏的配置都放在了一个目录
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
最好添加一份算法的描述文档
辛苦添加一份算法说明文挡 放在doc中 |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this valuable upstream to PaddleOCR, let's merge it.
No description provided.