Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Add _version.py to .gitignore and refine symbolic module #684

Merged
merged 2 commits into from
Dec 8, 2023

Conversation

HydrogenSulfate
Copy link
Collaborator

PR types

Bug fixes

PR changes

Others

Describe

  1. 添加 _version.py.gitignore
  2. symbolic 模块适配 sdf 函数,并添加单测

Copy link

paddle-bot bot commented Dec 8, 2023

Thanks for your contribution!

Copy link
Collaborator

@zhiminzhang0830 zhiminzhang0830 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit 029a965 into PaddlePaddle:develop Dec 8, 2023
3 of 4 checks passed
@HydrogenSulfate HydrogenSulfate deleted the ignore_ver branch December 8, 2023 04:49
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
…ePaddle#684)

* add ppsci/_version.py to .gitignore

* refine symbolic code for sdf and add unitest for complicated symbolic computation case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants