Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【PPSCI Doc No.58、59、60】Mesh.from_pymesh、translate、scale #818

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

smallpoxscattered
Copy link
Contributor

@smallpoxscattered smallpoxscattered commented Mar 22, 2024

PR types

Others

PR changes

Docs

Describe

任务链接:#686 No. 58-60
完善 ppsci.geometry.Mesh内from_pymesh、translate、scale函数

Copy link

paddle-bot bot commented Mar 22, 2024

Thanks for your contribution!

Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,感谢提交PR

[1. 0. 1.]
[1. 1. 1.]
[0. 1. 1.]]
>>> print(mesh.translate((-0.5, 0, 0.5), 0).vertices) # the center is moved to the translation vector.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用True或False代替0/1

[ 0. -0.5 1. ]
[ 0. 0.5 1. ]
[-1. 0.5 1. ]]
>>> print(mesh.translate((-0.5, 0, 0.5), 1).vertices) # the translation vector is directly added to the geometry coordinates
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

使用True或False代替0/1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的好的,谢谢

@luotao1 luotao1 added the HappyOpenSource 快乐开源活动issue与PR label Mar 25, 2024
@luotao1
Copy link
Collaborator

luotao1 commented Mar 25, 2024

仿照下面的PR,改一下PR标题和描述

@HydrogenSulfate HydrogenSulfate changed the title update mesh.py 【PPSCI Doc No.58、59、60】Mesh.from_pymesh、translate、scale Mar 25, 2024
Copy link
Collaborator

@HydrogenSulfate HydrogenSulfate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HydrogenSulfate HydrogenSulfate merged commit a9dd9f8 into PaddlePaddle:develop Mar 25, 2024
3 of 4 checks passed
huohuohuohuohuo123 pushed a commit to huohuohuohuohuo123/PaddleScience that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributor HappyOpenSource 快乐开源活动issue与PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants