Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the bug of feature fusion(FeatureFusionModule) module in FastSCNN #756

Merged
merged 1 commit into from
Jan 4, 2021
Merged

Fix the bug of feature fusion(FeatureFusionModule) module in FastSCNN #756

merged 1 commit into from
Jan 4, 2021

Conversation

chliang
Copy link
Contributor

@chliang chliang commented Jan 4, 2021

Fix the bug of feature fusion(FeatureFusionModule) module in FastSCNN(fast_scnn.py).

michaelowenliu
michaelowenliu reviewed Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@michaelowenliu michaelowenliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a bug here, just two different usages. Does it report an error while running the model?

@michaelowenliu michaelowenliu self-assigned this Jan 4, 2021
@chliang
Copy link
Contributor Author

chliang commented Jan 4, 2021

not a bug here, just two different usages. Does it report an error while running the model?

在某些图像尺寸输入（比如高度500），到特征融合这一层，两个需要融合的特征融合的shape 不一致，无法融合

@michaelowenliu
Copy link
Collaborator

not a bug here, just two different usages. Does it report an error while running the model?

在某些图像尺寸输入（比如高度500），到特征融合这一层，两个需要融合的特征融合的shape 不一致，无法融合

是的，非32的倍数会有问题，我们尽快评估下这个需求。

wuyefeilin
wuyefeilin approved these changes Jan 4, 2021
View reviewed changes
Copy link
Collaborator

@wuyefeilin wuyefeilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelowenliu
Copy link
Collaborator

not a bug here, just two different usages. Does it report an error while running the model?

在某些图像尺寸输入（比如高度500），到特征融合这一层，两个需要融合的特征融合的shape 不一致，无法融合

@michaelowenliu michaelowenliu reopened this Jan 4, 2021
@michaelowenliu michaelowenliu merged commit 0b0ab8c into PaddlePaddle:release/v2.0.0-rc Jan 4, 2021
@michaelowenliu michaelowenliu added the contributor Contribution from developers label Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wuyefeilin wuyefeilin wuyefeilin approved these changes

@michaelowenliu michaelowenliu michaelowenliu approved these changes

Assignees

@michaelowenliu michaelowenliu

Labels
contributor Contribution from developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chliang @michaelowenliu @wuyefeilin