Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

【Hackathon 8th No.7】Python版本适配 3 #3969

Merged
merged 6 commits into from
Jan 21, 2025

Conversation

Liyulingyue
Copy link
Contributor

@Liyulingyue Liyulingyue commented Jan 16, 2025

PR types

Others

PR changes

Others

Describe

移除对部分依赖库的版本限制

基于 https://github.com/timmahrt/praatIO/blob/main/UPGRADING.md#version-5-to-6-migration

  • Instead of using with Textgrid.tierDict directly, please use Textgrid.addTier(), Textgrid.getTier(), Textgrid.removeTier(), and Textgrid.renameTier()
  • TextgridTier.entryList was renamed to TextgridTier.entries and made read only. Please use TextgridTier.insertEntry() and TextgridTier.deleteEntry() if you need to modify it.

setup.py Outdated
@@ -56,10 +56,10 @@
"paddleslim>=2.3.4",
"ppdiffusers>=0.9.0",
"paddlespeech_feat",
"praatio>=5.0.0, <=5.1.1",
"praatio",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to test if MFA can work

"prettytable",
"pydantic>=1.10.14, <2.0",
"pypinyin<=0.44.0",
"pydantic",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check #3715 whether work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix with Optional[str]

@mergify mergify bot added the Server label Jan 16, 2025
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zxcd zxcd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zxcd zxcd merged commit 85de840 into PaddlePaddle:develop Jan 21, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants