Fix test_snapshot.py #3976
Merged
Fix test_snapshot.py #3976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxcd
reviewed
Jan 22, 2025
|
|
||
| # from paddlespeech.t2s.training.updater import StandardUpdater |
There was a problem hiding this comment.
StandardUpdater in paddlespeech/t2s/training/updaters/standard_updater.py
There was a problem hiding this comment.
测试standard_updater.py中StandardUpdater不能使用，提示少logger
There was a problem hiding this comment.
如果跑不通确实可以取消了这个单测，以及目前启用的单测可见tests/unit/ci.sh，建议目前仅关注启用的单测即可。
There was a problem hiding this comment.
好的那运行tests/unit/ci.sh测试，同时这个PR的修改就是取消这个单测
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types
Others
PR changes
Others
Describe
paddlespeech.t2s.training.updater 没有 StandardUpdater，取消单测 test_snapshot