[PaddlePaddle Hackathon] add paddle.nn.ClipGradByNorm单测 #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…test_clip_grad_by_norm.py, modify test_pixel_shuffle.py
kolinwei
requested changes
Oct 27, 2021
| try: | ||
| paddle_clip(paddle_data) | ||
| except RuntimeError: | ||
| pass |
There was a problem hiding this comment.
您好，apibase的exception运行时，425行代码 _check_params函数会把data通过paddle.to_tensor转换成tensor，但是paddle.nn.ClipGradByGlobalNorm实例调用时传入的参数类型是list[tuple, tuple, tuple...]，会导致运行出错，所以才使用try except这种方式捕获异常。如果使用exception捕获异常的话，应该怎么修改呢？
There was a problem hiding this comment.
这里直接使用 with pytest.raises 方式吧
There was a problem hiding this comment.
不好意思，之前的没通过ci，现在已经OK了。
…to test_ClipGradByNorm
…to test_ClipGradByNorm
kolinwei
approved these changes
Nov 1, 2021
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR types：New features
PR changes：APIs
Describe
Task: #35962
添加paddle.nn.ClipGradByNorm单测，PaddleTest\framework\api\nn\test_clip_grad_by_norm.py