【Hackathon No.21】 #32
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
miao.du seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Duum
force-pushed
the
dumm-softmarginloss
branch
from
4ebbf1c
to
e2ab9ee
Compare
Duum
force-pushed
the
dumm-softmarginloss
branch
from
e2ab9ee
to
24b2793
Compare
|
PR 格式检查通过，你的PR 将接受Paddle 专家以及开源社区的review，请及时关注PR 动态 |
DDDivano
reviewed
Mar 18, 2022
| _margin_loss | ||
| # 六、测试和验收的考量 | ||
| - Loss准确度的测试。 | ||
| - 1D，2D tensor的表现行为和pytorch表现一致 |
|
你的PR有最新反馈，请及时修改。 |
yingyibiao
reviewed
Mar 28, 2022
Comment on lines
+76
to
+77
| ## 命名与参数设计 | ||
| 参考：[飞桨API 设计及命名规范](https://www.paddlepaddle.org.cn/documentation/docs/zh/develop/dev_guides/api_contributing_guides/api_design_guidelines_standard_cn.html) |
There was a problem hiding this comment.
需要明确具体 API 实现接口以及接口参数设计。
yingyibiao
reviewed
Mar 28, 2022
Comment on lines
+78
to
+79
| ## 底层OP设计 | ||
| 添加到paddle最新维护的phi计算库中。 |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
添加 SoftMarginLoss的设计文档