Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

【Hackathon No.65】Added RFC for Web Model Converter #86

Merged
merged 3 commits into from
Apr 21, 2022
Merged

【Hackathon No.65】Added RFC for Web Model Converter #86

merged 3 commits into from
Apr 21, 2022

Conversation

daquexian
Copy link
Contributor

@CLAassistant
Copy link

CLAassistant commented Mar 30, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@daquexian daquexian changed the title 【Hackathon No.64】Added RFC for Web Model Converter 【Hackathon No.65】Added RFC for Web Model Converter Mar 30, 2022
@paddle-bot-old
Copy link

你的PR提交成功，感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备，具体请参考示例和模版。
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

@dingjiaweiww dingjiaweiww mentioned this pull request Mar 31, 2022
Closed
@paddle-bot-old
Copy link

PR格式检查通过，你的PR将接受Paddle专家以及开源社区的review，请及时关注PR动态。
The format inspection passed. Your PR will be reviewed by experts of Paddle and developers from the open-source community. Stay tuned.

JingyuanZhang
JingyuanZhang reviewed Apr 19, 2022
View reviewed changes
rfcs/Lite/20200330_api_design_for_web_model_converter.md Outdated

# 五、设计思路与实现方案

使用 emsdk 将 opt 工具编译为 WebAssembly，集成进
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里没有写完？辛苦补全实现方案

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

抱歉，已经补全啦

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JingyuanZhang 辛苦再看下~

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌🏻

@paddle-bot-old
Copy link

你的PR有最新反馈，请及时修改。
There’s the latest feedback about your PR. Please check.

@TCChenlong TCChenlong merged commit f596e8a into PaddlePaddle:master Apr 21, 2022
@daquexian daquexian mentioned this pull request May 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JingyuanZhang JingyuanZhang JingyuanZhang approved these changes

@TCChenlong TCChenlong TCChenlong approved these changes

Assignees
No one assigned
Labels
contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@daquexian @CLAassistant @JingyuanZhang @TCChenlong @dingjiaweiww