Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

Vgg16 example #45

Merged
merged 8 commits into from
Jul 3, 2018
Merged

Vgg16 example #45

merged 8 commits into from
Jul 3, 2018

Conversation

kexinzhao
Copy link
Collaborator

No description provided.

@tonyyang-svail tonyyang-svail self-requested a review June 29, 2018 17:19
@@ -268,14 +269,14 @@ class BatchNorm {
framework::AttributeMap attrs;
attrs["shape"] = std::vector<int>{channel_in};
attrs["value"] = 1.0f;
scale_ = GlobalParameterCollection().AddBNParameter(
scale_ = GlobalParameterCollection().AddParameter(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent.


Adam adam(0.001);

auto vgg16_forward = [&](VariableHandle input) -> VariableHandle {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to support testing on batch norm, maybe do auto vgg16_forward = [&](VariableHandle input, bool is_test) -> VariableHandle {

filename1, {32, 3, 32, 32, 32, 1}, {4, 2}, {0, 0});
auto test_reader = CreateRecordioFileReader(
filename2, {32, 3, 32, 32, 32, 1}, {4, 2}, {0, 0});

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reminder: add batchnorm and pool.

@kexinzhao kexinzhao force-pushed the try_vgg16 branch 2 times, most recently from 01b1b52 to 16e244c Compare July 2, 2018 22:50
@kexinzhao kexinzhao changed the title [WIP] Vgg16 example Vgg16 example and add place to tape Jul 2, 2018
@tonyyang-svail tonyyang-svail changed the title Vgg16 example and add place to tape Vgg16 example Jul 2, 2018
Copy link
Collaborator

@tonyyang-svail tonyyang-svail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

auto vgg16_forward = [&](VariableHandle input,
bool is_test) -> VariableHandle {
paddle::framework::AttributeMap attrs;
attrs["is_test"] = is_test;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like bn and dropout are sharing an attribute. Maybe separate them?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. Will fix it in the next pr.

@kexinzhao kexinzhao merged commit fa0919e into PaddlePaddle:develop Jul 3, 2018
@kexinzhao kexinzhao deleted the try_vgg16 branch July 3, 2018 02:27
@tonyyang-svail tonyyang-svail mentioned this pull request Jul 4, 2018
36 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants