Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: removing pagerduty sync to limitation in Backstage #10

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

t1agob
Copy link
Contributor

@t1agob t1agob commented Jul 25, 2024

Description

This PR removes the logic of syncing from PagerDuty to Backstage. Due to a limitation on how entity relations are emitted in CatalogProcessor the relations existing on file cannot be removed from the entity. This adds some limits on the capacity to fully overwrite relations for an entity and therefore making impossible a full-sync from PagerDuty to Backstage to work.

Once/If the design limitation changes, this capability will be introduced once again.

Issue number: N/A

Type of change

  • New feature (non-breaking change which adds functionality)
  • Fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have performed a self-review of this change
  • Changes have been tested
  • Changes are documented
  • Changes generate no new warnings
  • PR title follows conventional commit semantics

If this is a breaking change 👇

  • I have documented the migration process
  • I have implemented necessary warnings (if it can live side by side)

Acknowledgement

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
@t1agob t1agob added the bug Something isn't working label Jul 25, 2024
Signed-off-by: Tiago Barbosa <tbarbos@hotmail.com>
@t1agob t1agob merged commit 1528bec into next Jul 25, 2024
2 checks passed
@t1agob t1agob deleted the feat/service-dependency-sync branch July 25, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant