Remove *http.Response returns from API methods

[theckman]

Currently we have some methods that return an *httpResponse, like this one:

go-pagerduty/ruleset.go

Line 170 in 1a0c44e

func (c *Client) CreateRuleset(r *Ruleset) (*Ruleset, *http.Response, error) {

Although, digging further I noticed that in many cases we read the response body and don't replace it:

go-pagerduty/ruleset.go

Line 174 in 1a0c44e

return getRulesetFromResponse(c, resp, err)

go-pagerduty/ruleset.go

Line 202 in 1a0c44e

if dErr := c.decodeJSON(resp, &target); dErr != nil {

go-pagerduty/client.go

Lines 314 to 318 in 1a0c44e

	func (c *Client) decodeJSON(resp *http.Response, payload interface{}) error {
	defer resp.Body.Close()
	decoder := json.NewDecoder(resp.Body)
	return decoder.Decode(payload)
	}

So, the only thing consumers can read from the *http.Response are the headers, and not the response. We should just remove this as one of the breaking changes in v1.5.0, since it never really worked.

Impacted Files

• business_service.go (Remove returned *http.Response from business svc related methods #358)
• incident.go (Remove returned *http.Response from incident-related methods #357)
• ruleset.go (Remove returned *http.Response from ruleset-related methods #361)
• service_dependency.go (Remove returned *http.Response from svc dependency related methods #359)
• tag.go (Remove returned *http.Response from tag-related methods #360)

Impacted Methods

• AssignTags
• AssignTagsWithContext
• AssociateServiceDependencies
• CreateBusinessService
• CreateRuleset
• CreateRulesetRule
• CreateRulesetRuleWithContext
• CreateTag
• CreateTagWithContext
• DisassociateServiceDependencies
• DisassociateServiceDependencies
• GetIncidentAlert
• GetRuleset
• GetRulesetRule
• GetTag
• GetTagWithContext
• ListBusinessServiceDependencies
• ListTechnicalServiceDependencies
• ManageIncidentAlerts
• UpdateBusinessService
• UpdateRuleset
• UpdateRulesetRule
• UpdateRulesetRuleWithContext

[theckman]

So I think I came up with a pattern we can use that allows us to remove this from the majority of the API, while also giving consumers a debug capability to allow them to capture the response if they need it. I'll raise a PR for that once v1.4.0 is out.

[theckman]

So to my comment above, that was #325 which is now merged. I can start looking at this, finally.

[theckman]

This is done.