Fix ruleset rule not respecting position "0" #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During the JSON marshal of a RulesetRule a Position with the value of "0" is considered empty and is not sent in the POST or PUT payload.
|
Yeah that's a bummer, but understandable. If it weren't such a big deal to have consumers upgrade to v2.0.0, I'd be OK with merging this and starting the v2 branch a la Chrome. What we may need to do is cut a breaking minor release, and treat it like a necessary 1.0 bugfix. What thoughts do others have? |
theckman
approved these changes
Aug 27, 2020
|
@theckman Agreed that a minor release sounds reasonable. I believe there are other breaking changes we'd want to incorporate into a full V2 release, and at the very least a more thorough pass on properly handling optional fields. Barring any objections I'll cut v1.3.0 later today. |
dobs
approved these changes
Sep 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the JSON marshal of a
RulesetRule, aPositionwith the value of0is considered empty and is not sent in the POST or PUT payload. Using a pointer allows the JSON marshal function to distinguish between an empty value and a default value.I'm not sure how this change would be handled as it isn't really backwards compatible. Happy to hear any thoughts or opinions.