-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add assignees to log entry #237
Add assignees to log entry #237
Conversation
@@ -35,6 +35,7 @@ type CommonLogEntryField struct { | |||
Contexts []Context `json:"contexts,omitempty"` | |||
AcknowledgementTimeout int `json:"acknowledgement_timeout"` | |||
EventDetails map[string]string `json:"event_details,omitempty"` | |||
Assignees []APIObject `json:"assignees,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tautvydass I've seen @stmcallister make earlier comments about not wanting to accept changes to this library that rely on undocumented API features. Looking through the API docs I don't see this field documented, and so I worry that this might not be accepted.
@stmcallister would you be able to confirm that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In hunting around, I've discovered this is obscurely documented. I'll take it.
I've raised a support ticket with PagerDuty to get the status of this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this and for your patience! 🎉 🎉 🎉
@stmcallister happy to merge this, but I don't yet see this in the docs on the site: https://developer.pagerduty.com/api-reference/b3A6Mjc0ODE1NA-list-log-entries |
'Assign' log entries have assignees field.