Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add assignees to log entry #237

Merged

Conversation

tautvydass
Copy link
Contributor

'Assign' log entries have assignees field.

@@ -35,6 +35,7 @@ type CommonLogEntryField struct {
Contexts []Context `json:"contexts,omitempty"`
AcknowledgementTimeout int `json:"acknowledgement_timeout"`
EventDetails map[string]string `json:"event_details,omitempty"`
Assignees []APIObject `json:"assignees,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tautvydass I've seen @stmcallister make earlier comments about not wanting to accept changes to this library that rely on undocumented API features. Looking through the API docs I don't see this field documented, and so I worry that this might not be accepted.

@stmcallister would you be able to confirm that?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In hunting around, I've discovered this is obscurely documented. I'll take it.

@theckman theckman added open question there is an open question on the issue / PR undocumented feature This PR or issue is trying to make use of a feature not yet documented by PagerDuty labels Feb 20, 2021
@theckman
Copy link
Collaborator

I've raised a support ticket with PagerDuty to get the status of this.

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this and for your patience! 🎉 🎉 🎉

@theckman
Copy link
Collaborator

@theckman
Copy link
Collaborator

@theckman theckman merged commit f83a7dd into PagerDuty:master Nov 11, 2021
@theckman theckman added this to the v1.5.0 milestone Nov 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open question there is an open question on the issue / PR undocumented feature This PR or issue is trying to make use of a feature not yet documented by PagerDuty
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants