Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ruleset: remove omitempty from Route #256

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

GiedriusS
Copy link
Contributor

Remove omitempty from Route because otherwise it is impossible to
remove a route from the catch-all rule by calling UpdateRulesetRule().

Remove `omitempty` from Route because otherwise it is impossible to
remove a route from the catch-all rule by calling UpdateRulesetRule().
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉 👍

@stmcallister stmcallister merged commit 8796b5a into PagerDuty:master Dec 11, 2020
@theckman theckman added this to the v1.4.0 milestone Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants