-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add ListServicesPaginated to services api (and tests) #260
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think overall this is something we'd like to get merged in. There are some merge conflicts that need resolved, as well as some other non-conflicts that need updating, before we could merge this in.
Please let me know if you have any questions or comments on my feedback. Thank you for the contribution! 👍
Comments addressed @theckman, I used the strings.Contains() approach from above, but if theres a reason to iterate manually, I can do that too. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry, I noticed two more minor things and then this is ready for merging!
@theckman done once again. |
@c6h12o6 git is awful and caught a merge conflict based on another PR we merged in. I'll fix it on merge in just a moment. |
@c6h12o6 thank you for the contribution! |
Added new functionality to easily leverage pagedGet() in ListServices. Does not alter any existing functionality.