-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Analytics #261
Analytics #261
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few changes in here that need to be made because of changes elsewhere in this library since the PR was opened.
In addition I see signs of go fmt
not being ran on this code, unhandled errors, and what look like remnants of code copying from other files within the project. There are also some style changes (such as using Id
instead of ID
).
@melchiormoulin I've included this in the v1.4.0 milestone, as we're planning to make v1.5.0 a special release and I want to get as many features / bugfixes as I can into the v1.4.x line. I don't have a specific timeline for when we hope to get that out, but if you don't feel like you'll have time to dedicate to this PR in the near-term I can target this for v1.6.0. |
Hello @theckman It's been a while i've made this pr, i'm not available right now but I can do this this weekend is that ok for you? |
@melchiormoulin most definitely! Thank you. |
From team_id or service_id stats on incident. You can tweak the start and end date and the urgency. The aggregation is overday for now The timezone is in UTC for now
c106539
to
9f1e5be
Compare
You can review it @theckman |
@melchiormoulin thank you so much! I'm currently heads-down on implementing #267 throughout the package, and will take a look at your PR when I finish that (ideally this weekend, or early this coming week at the latest). |
Hello @theckman, |
@melchiormoulin sorry for the delay in that review, was working on getting the torrent of (still open) PRs raised to add |
Hello @theckman no worries, this is done. |
Thank you so much for the contribution. I'll merge it shortly, and it will be included eventually in the |
Hello @theckman, |
Add the analytics endpoint Get aggregated incident data
https://developer.pagerduty.com/api-reference/reference/REST/openapiv3.json/paths/~1analytics~1metrics~1incidents~1all/post