Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds the ability to define an escalation policy for the manage incidents API #273

Closed
wants to merge 2 commits into from
Closed

Adds the ability to define an escalation policy for the manage incidents API #273

wants to merge 2 commits into from

Conversation

evnsio
Copy link
Contributor

@evnsio evnsio commented Feb 15, 2021

No description provided.

@theckman theckman added this to the v1.4.0 milestone Feb 20, 2021
theckman
theckman requested changes Feb 20, 2021
View reviewed changes
incident.go
Status string `json:"status,omitempty"`
Priority *APIReference `json:"priority,omitempty"`
Assignments []Assignee `json:"assignments,omitempty"`
EscalationPolicy *EscalationPolicy `json:"escalation_policy,omitempty"`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I know this is technically an EscalationPolicy, looking at the PagerDuty API documentation it seems like this expects the APIObject subset of the EscalationPolicy type.

I'm not sure if the PagerDuty will always return success if we rendered the other EscalationPolicy fields in the JSON document. That makes me think we should update this to be an *APIObject.

What are your thoughts?

@theckman theckman mentioned this pull request Feb 20, 2021
Open
@theckman
Copy link
Collaborator

theckman commented Mar 8, 2021

@evnsio I wanted to see if you saw my comment above, and whether you might have the spare cycles to make the suggested iteration?

@theckman
Copy link
Collaborator

theckman commented Mar 18, 2021 •
edited
Loading

@evnsio I wanted to ping again to see if you could make the *APIObject change above. This is looking like it'll soon be the only thing left open for v1.4.0.

@evnsio
Copy link
Contributor Author

evnsio commented Mar 19, 2021

Sorry I completely missed these notifications. I'll take a look over the weekend if that works?

@theckman
Copy link
Collaborator

@evnsio absolutely! I really appreciate you making the time.

@theckman
Copy link
Collaborator

@evnsio just wanted to ping a final time. This is the final item outstanding for v1.4.0, and I'd like to get us towards releasing that. If you're not free it's no sweat, please let me know and I'm happy to make this change.

theckman added a commit that referenced this pull request Apr 20, 2021
@theckman
Add ability to set Escalation Policy when managing incidents
5500812 
This was originally suggested by @evnsio in #273, but there were some challenges
getting that PR shephered through and so this is being reintroduced as a new PR.

Replaces #273
@theckman theckman mentioned this pull request Apr 20, 2021
Merged
@theckman theckman removed this from the v1.4.0 milestone Apr 20, 2021
@theckman
Copy link
Collaborator

Thank you for raising this PR / feature request. I've raised a complimentary PR (#323) that supersedes this one. I'll close this PR at this time.

Although we did not get to merge your PR, we appreciate the contribution!

@theckman theckman closed this Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theckman theckman theckman requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@evnsio @theckman