return nil instead of resp on error #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
approved these changes
Feb 20, 2021
theckman
requested changes
Feb 20, 2021
event.go
Outdated
| @@ -49,7 +49,7 @@ func CreateEventWithHTTPClient(e Event, client HTTPClient) (*EventResponse, erro | |||
| req.Header.Set("Content-Type", "application/json") | |||
| resp, err := client.Do(req) | |||
| if err != nil { | |||
| return &EventResponse{HttpStatus: resp.StatusCode}, err | |||
| return nil, fmt.Errorf("failed to action request: %w", err) | |||
There was a problem hiding this comment.
Would you be able to go fmt this file? Just noticed the whitespace before nil when getting ready to merge.
|
@blockpane wanted to ping again to see if you had a moment to remove the leading whitespace on your change. If not give me a shout. |
|
@theckman Sorry, just caught this request, should be fixed. |
theckman
approved these changes
Mar 6, 2021
|
@blockpane thank you for this contribution. It'll probably still be a few days until v1.4.0 is out, and it'll be included there. If you or anyone else is running into issues with this actively, please give us a shout via a GitHub issue and I can work on backporting just that change as v1.3.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent nil reference on error, resolves #274