-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update extension_schema.go to accept a context.Context #289
Conversation
type ListExtensionSchemaResponse struct { | ||
APIListObject | ||
ExtensionSchemas []ExtensionSchema `json:"extension_schemas"` | ||
} | ||
|
||
// ListExtensionSchemaOptions are the options to send with the | ||
// ListExtensionSchema reques(s). | ||
type ListExtensionSchemaOptions struct { | ||
APIListObject | ||
Query string `url:"query,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stmcallister I don't see this field documented here. Does this look like a candidate for removal as part of 1.5, or should this remain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, now that I look more maybe it's implicitly supported so that you can get the total count as part of the paginated response?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've reached out to our engineering team to see if we can document the query
query string parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stmcallister since this something we can (and should) solve outside of this PR, are we good to merge this one to call the context.Context
addition done?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
Updates #267