Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update log_entry.go to accept a context.Context #291

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Update log_entry.go to accept a context.Context #291

merged 1 commit into from
Mar 10, 2021

Conversation

theckman
Copy link
Collaborator

Updates #267

@theckman theckman added this to the v1.4.0 milestone Feb 26, 2021
@theckman theckman mentioned this pull request Feb 26, 2021
Closed
22 tasks
stmcallister
stmcallister approved these changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@stmcallister stmcallister merged commit e2d111a into master Mar 10, 2021
@stmcallister stmcallister deleted the ctx_log_entry branch March 10, 2021 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@theckman @stmcallister