-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Service Event Rules #304
Conversation
* Adding "suspend" action to rule actions * Adding Service Event Rules support
* General updates, adding service rule list cli command * Adding service rule show command
@mrzacarias I'll get to reviewing this in the coming days, once I finish a set of PRs I am raising against the repo. Thank you for the contribution. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there, I've some other PRs in flight that are making some fairly large changes to the internals of this package. Unfortunately, your PR is overlapping with some of those and so I've requested changes to have this code align more closely to what changes I am making there. That includes things like accepting a context.Context
, no longer returning a *http.Response
from API methods, and only using pointer types where they make sense for semantic reasons.
Please let me know if you have any questions about this feedback. 👍
196939d
to
2fd77dc
Compare
@theckman Thanks for carefully reviewing this PR :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrzacarias I think I may have found two more minor things that didn't dawn on me before. Since changing the types would be a breaking change after release, I want to make sure we get this right.
Happy to be wrong with my requested changes, if so give me a shout.
@mrzacarias thank you for the contribution. There are still a few changes in-flight for Thanks again! |
Adding support for Service Event Rules. API reference:
List Service's Event Rules
Get an Event Rule from a Service
Delete an Event Rule from a Service
Create an Event Rule on a Service
Update an Event Rule on a Service
Some other changes:
Edit: Forgot to mention, but I got trouble making the CLI logic work without changing the references to our own fork, so I commented the code for now. As soon as we merge this PR, we can have the implemented CLI commands working by uncommenting this code.