Update schedule.go to accept a context.Context; fix fatal bug #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While adding `context.Context` support to the `schedule.go` file, I found a `nil` map write in PreviewSchedule(). This makes me believe this method may be unused, otherwise I would expect a panic report. Updates #267
theckman
commented
Mar 6, 2021
| v, err := query.Values(o) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| var data map[string]Schedule | ||
| data["schedule"] = s |
There was a problem hiding this comment.
These two lines being removed are the bug I am referring to.
There was a problem hiding this comment.
Nice catch! I have been able to reproduce the bug you mentioned and verified that this approach no longer panics.
22 tasks
stmcallister
approved these changes
Mar 17, 2021
| v, err := query.Values(o) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| var data map[string]Schedule | ||
| data["schedule"] = s |
There was a problem hiding this comment.
Nice catch! I have been able to reproduce the bug you mentioned and verified that this approach no longer panics.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While adding
context.Contextsupport to theschedule.gofile, I found anilmap write in PreviewSchedule(). This makes me believe this method may beunused, otherwise I would expect a panic report.
Updates #267