-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update team.go to accept a context.Context #308
Conversation
|
||
// AddUserToTeamWithContext adds a user to a team. | ||
func (c *Client) AddUserToTeamWithContext(ctx context.Context, o AddUserToTeamOptions) error { | ||
_, err := c.put(ctx, "/teams/"+o.TeamID+"/users/"+o.UserID, o, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diff section above this comment was inspired by #262.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
|
||
// AddUserToTeamWithContext adds a user to a team. | ||
func (c *Client) AddUserToTeamWithContext(ctx context.Context, o AddUserToTeamOptions) error { | ||
_, err := c.put(ctx, "/teams/"+o.TeamID+"/users/"+o.UserID, o, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this approach.
Replaces #262
Updates #267