teams and services analytics endpoints #312
Conversation
analytics.go
Outdated
| @@ -9,6 +9,7 @@ type AnalyticsRequest struct { | |||
| AggregateUnit string `json:"aggregate_unit,omitempty"` | |||
| TimeZone string `json:"time_zone,omitempty"` | |||
| } | |||
|
|
|||
| type AnalyticsResponse struct { | |||
| Data []AnalyticsData `json:"data,omitempty"` | |||
| AnalyticsFilter *AnalyticsFilter `json:"filters,omitempty"` | |||
There was a problem hiding this comment.
Apologies for asking this of you since this wasn't your change, but your PR made me look at things again and I am now realizing I missed this in the original PR. Would you rename this field in your PR to just be Filters *AnalyticsFilter. We've not released this yet, and so I'd rather we get this done right versus letting it bleed out once we do release v1.4.0.
There was a problem hiding this comment.
AnalyticsFilter has been changed to Filters 👍
There was a problem hiding this comment.
I think you may have misread my comment, I'm sorry. Was only wanting the field name updated, not the type too. The type made sense because it's the filters for the Analytics stuff, but AnalyticsResponse.AnalyticsFilters stutters a little bit, while AnalyticsResponse.Filters is easier to communicate.
There was a problem hiding this comment.
I did misread your comment. Apologies 😅 I went ahead and changed that in the new commit. Please let me know if you see anything else 👍
Add aggregated analytics endpoints for Teams and Services
https://developer.pagerduty.com/api-reference/reference/REST/openapiv3.json/paths/~1analytics~1metrics~1incidents~1services/post
https://developer.pagerduty.com/api-reference/reference/REST/openapiv3.json/paths/~1analytics~1metrics~1incidents~1teams/post