implement missing maintenance-window subcommands #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
requested changes
Sep 28, 2021
Hsn723
force-pushed
the
implement-maintenance-window-command
branch
from
25b01e0
to
b3cc824
Compare
|
@theckman |
theckman
approved these changes
Oct 1, 2021
There was a problem hiding this comment.
Thank you for your contribution, as well as working with me on the requested changes. It'll probably still take a little bit of time until the v1.5.0 tag is cut on the repo, but within the next few minutes your changes should be available on the master branch if you'd like to start making use of them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
pd maintenance-windowcommand was missing subcommands other thancreate, so I went ahead and implemented them.createis also using a deprecated library function so I also addressed that.