-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement missing maintenance-window subcommands #363
implement missing maintenance-window subcommands #363
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. I did request a few changes.
25b01e0
to
b3cc824
Compare
@theckman |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution, as well as working with me on the requested changes. It'll probably still take a little bit of time until the v1.5.0
tag is cut on the repo, but within the next few minutes your changes should be available on the master
branch if you'd like to start making use of them.
The
pd maintenance-window
command was missing subcommands other thancreate
, so I went ahead and implemented them.create
is also using a deprecated library function so I also addressed that.