Adding escalation level to ManageIncidentOptions #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
theckman
requested changes
Sep 28, 2021
| @@ -210,6 +210,42 @@ func TestIncident_Manage_assignments(t *testing.T) { | |||
| testEqual(t, want, res) | |||
| } | |||
|
|
|||
| func TestIncident_Manage_esclation_level(t *testing.T) { | |||
There was a problem hiding this comment.
What are we actually testing here? It doesn't seem like we do anything to confirm that the escalation_level field is passed in the JSON in the request body.
Would it make sense to update the HTTP handler to parse the JSON request body in this test, and fail if the escalation_level JSON key is either missing or not the expected value?
|
@sim1s wanted to see if you'd have some time to take a look at the question I had in the requested changes. |
theckman
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.