Add support for adding email filters for Generic Email Integrations #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for adding different email filter rules to a generic
inbound email integration associated with a specific Service. This is done by
adding two new fields to the Integration struct.
While implementing this functionality I found that the API documentation from
PagerDuty lacked details about what the correct values are for specific fields,
and specifically what each value means. In fact, I actually had to go into the
PagerDuty UI to try and set up email filters, so that I could guess what the
different API values actually meant.
Because of that, I chose to create an enum-like type for each thing that wasn't
well documented to make it easier to consume via this client. That's resulted in
quite a lot of extra code, but the result is that anyone who wishes to consume
this area of the Go SDK should be able to figure it out how to use it without
much trouble.
Because of how the code grew, I also chose to move the Service
Integration-specific code into a new file (service_integration.go).
Closes #315