Mark Type struct field deprecated, for incident creation + management #392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stmcallister
approved these changes
Nov 15, 2021
We should not expect consumers to set this value, as there is only a single value that is valid (`incident`) based on how we use the API. As such, let's deprecate the field and just set it in the methods that need it. This also updates the tests to assert that we're automatically setting it appropriately. Closes #390
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should not expect consumers to set this value, as there is only a single
value that is valid (
incident) based on how we use the API. As such, let'sdeprecate the field and just set it in the methods that need it.
This also updates the tests to assert that we're automatically setting it
appropriately.
Closes #390