Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Second batch of fixes for API incompatibilities #414

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Second batch of fixes for API incompatibilities #414

merged 1 commit into from
Jan 19, 2022

Conversation

theckman
Copy link
Collaborator

Updates #389

@theckman theckman added this to the v1.5.0 milestone Jan 16, 2022
@theckman theckman mentioned this pull request Jan 16, 2022
Closed
26 tasks
@theckman theckman added the breaking change This PR contains a breaking change label Jan 16, 2022
@theckman theckman force-pushed the issue_389_2 branch 5 times, most recently from 822a59a to 0ad1e27 Compare January 18, 2022 08:16
stmcallister
stmcallister approved these changes Jan 19, 2022
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another good looking PR! Especially appreciate the commenting that you've added as well! 🎉

@theckman theckman merged commit 91a25f6 into master Jan 19, 2022
@theckman theckman deleted the issue_389_2 branch January 19, 2022 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
breaking change This PR contains a breaking change
Projects
None yet
Milestone
v1.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@theckman @stmcallister