Find a way to gracefully avoid one breaking change in #405 #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In #405 I opted to rename one of the types to be more consistent, and in the moment totally forgot about type aliases. A type alias allows you to rename a type in a non-breaking way, by converting the old name to be an alias to the new one. This change does that, and effectively removes one breaking change from v1.5.0. I also do the sane thing to unify the Priority type into one.
theckman
force-pushed
the
maintain_api_compatibility
branch
from
1bd67db to
428048d
Compare
stmcallister
approved these changes
Jan 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #405 I opted to rename one of the types to be more consistent, and in the
moment totally forgot about type aliases. A type alias allows you to rename a
type in a non-breaking way, by converting the old name to be an alias to the new
one.
This change does that, and effectively removes one breaking change from v1.5.0.
I also do the sane thing to unify the Priority type into one.