Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return custom error type for Events API (V2) calls #419

Merged
merged 2 commits into from
Feb 5, 2022
Merged

Conversation

theckman
Copy link
Collaborator

This was originally opened via #368, but the original author didn't seem able to be able address the last round of feedback. So I squashed all of their commits into one, and then added a second commit to address my feedback from that PR.

Closes #368

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finishing this one up! 👍

abhishekrb19 and others added 2 commits February 5, 2022 00:30
The original author didn't seem to have the spare cycles to address the feedback
on the PR, so I squashed their commits into one and then added this commit to
address the feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants