Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix potential panic when debug request captures are enabled #443

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

theckman
Copy link
Collaborator

This fixes a panic that would occur if we attempted to duplicate a request that
has a nil Body, which would be any GET request. This also adds a regression
test.

This fixes a panic that would occur if we attempted to duplicate a request that
has a nil Body, which would be any `GET` request. This also adds a regression
test.
@theckman theckman added this to the v1.6.0 milestone Apr 23, 2022
@theckman
Copy link
Collaborator Author

@stmcallister the build looks to have passed, but I don't see the status being reflected here. 🤔 https://app.circleci.com/pipelines/github/PagerDuty/go-pagerduty?branch=fix_captured_request_panic&filter=all

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! And, thank you for adding the test! 👍

@stmcallister stmcallister merged commit f756ba1 into master Aug 25, 2022
@ChuckCrawford ChuckCrawford deleted the fix_captured_request_panic branch September 21, 2022 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants