-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Event Orchestrations API #450
Implement Event Orchestrations API #450
Conversation
@theckman or @ChuckCrawford please take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EronWright : thank you for doing this and my apologies for the delay here.
I have left a couple of minor initial comments.
I have not been able to fully review the OrchestrationRouter
work for correctness quite yet. We were just thinking about preparing a 1.6.0 release. How would you feel about us targeting this for a 1.7.0 release so that folks have time to test this properly?
@EronWright : I promise I have not forgotten about this. I am just not as familiar with this API yet and am trying to check on a few things along the way here. I will get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay I have left a few comments / suggestions.
If you can resolve the merge conflicts (maybe rebase off of main?), fix the build, and address the few comments then we should be okay to merge this.
4319f74
to
6b0d41d
Compare
@ChuckCrawford your feedback has been addressed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for contributing this [and for your patience with the review process] @EronWright!
Closes #424
Implements the full Event Orchestrations API, including:
Also implements minimal CLI commands.