Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Event Orchestrations API #450

Merged

Conversation

EronWright
Copy link
Contributor

@EronWright EronWright commented Jun 27, 2022

Closes #424

Implements the full Event Orchestrations API, including:

  • List Event Orchestrations
  • Get an Orchestration
  • Update an Orchestration
  • Delete an Orchestration
  • Create an Orchestration
  • Get the Router for a Global Event Orchestration
  • Update the Router for a Global Event Orchestration
  • Get the Unrouted Orchestration for a Global Event Orchestration
  • Update the Unrouted Orchestration for a Global Event Orchestration
  • Get the Service Orchestration for a Service
  • Update the Service Orchestration for a Service
  • Get the Service Orchestration active status for a Service
  • Update the Service Orchestration active status for a Service

Also implements minimal CLI commands.

@EronWright
Copy link
Contributor Author

@theckman or @ChuckCrawford please take a look.

Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EronWright : thank you for doing this and my apologies for the delay here.

I have left a couple of minor initial comments.

I have not been able to fully review the OrchestrationRouter work for correctness quite yet. We were just thinking about preparing a 1.6.0 release. How would you feel about us targeting this for a 1.7.0 release so that folks have time to test this properly?

event_orchestration.go Outdated Show resolved Hide resolved
event_orchestration.go Show resolved Hide resolved
@ChuckCrawford ChuckCrawford added this to the v1.7.0 milestone Sep 21, 2022
@ChuckCrawford
Copy link
Collaborator

@EronWright : I promise I have not forgotten about this. I am just not as familiar with this API yet and am trying to check on a few things along the way here. I will get back to you soon.

Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay I have left a few comments / suggestions.

If you can resolve the merge conflicts (maybe rebase off of main?), fix the build, and address the few comments then we should be okay to merge this.

event_orchestration.go Outdated Show resolved Hide resolved
event_orchestration.go Outdated Show resolved Hide resolved
event_orchestration.go Show resolved Hide resolved
@EronWright EronWright force-pushed the issue-424-event-orchestration branch from 4319f74 to 6b0d41d Compare September 30, 2022 17:17
@EronWright
Copy link
Contributor Author

@ChuckCrawford your feedback has been addressed.

Copy link
Collaborator

@ChuckCrawford ChuckCrawford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contributing this [and for your patience with the review process] @EronWright!

@ChuckCrawford ChuckCrawford merged commit b6aa0d7 into PagerDuty:main Oct 7, 2022
@EronWright EronWright deleted the issue-424-event-orchestration branch October 7, 2022 16:11
gringus pushed a commit to gringus/go-pagerduty that referenced this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Event Orchestrations API
2 participants