Prevent leak on error responses

[ChuckCrawford]

Reverts #453 and instead applies the fix in a common location.

[acloudgopher-pd]

Looks ok to me all tests pass, but I'm a bit curious why only check for non json content

[ChuckCrawford]

Looks ok to me all tests pass, but I'm a bit curious why only check for non json content

Ah good question @acloudgopher-pd. I should have left some comments describing my thought process. So all of the requests eventually call c.checkResponse(resp, err) which has some common handling of non-2xx status codes:

go-pagerduty/client.go

Lines 583 to 585 in 8895770

	if resp.StatusCode < 200 || resp.StatusCode > 299 {
	return resp, c.getErrorFromResponse(resp)
	}

inside of getErrorFromResponse, the call to decodeJSON has handling to close the response body:

go-pagerduty/client.go

Lines 560 to 566 in 8895770

	func (c *Client) decodeJSON(resp *http.Response, payload interface{}) error {
	// close the original response body, and not the copy we may make if
	// debugCaptureResponse is true
	orb := resp.Body
	defer func() { _ = orb.Close() }() // explicitly discard error
	body, err := ioutil.ReadAll(resp.Body)

so it looked like the only place this was missing was for the scenario where a non-JSON response was returned...

[rafusel]

This looks like a better approach to me 👍