Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Unsetting of numloops Issue #324

Merged
merged 1 commit into from
Apr 30, 2021
Merged

Fixing Unsetting of numloops Issue #324

merged 1 commit into from
Apr 30, 2021

Conversation

stmcallister
Copy link
Contributor

@stmcallister stmcallister commented Apr 12, 2021 •
edited
Loading

This PR fixes #323 where pagerduty_escalation_policy.num_loops could not be unset. Test results are as follows.

TF_ACC=1 go test -run "TestAccPagerDutyEscalationPolicy" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyEscalationPolicy_import
--- PASS: TestAccPagerDutyEscalationPolicy_import (8.03s)
=== RUN   TestAccPagerDutyEscalationPolicy_Basic
--- PASS: TestAccPagerDutyEscalationPolicy_Basic (9.22s)
=== RUN   TestAccPagerDutyEscalationPolicyWithTeams_Basic
--- PASS: TestAccPagerDutyEscalationPolicyWithTeams_Basic (9.23s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	28.098s

@stmcallister stmcallister changed the title Fixing numloops Issue Fixing Unsetting of numloops Issue Apr 12, 2021
@stmcallister stmcallister requested a review from dobs April 12, 2021 21:16
@stmcallister stmcallister merged commit 7c964f9 into PagerDuty:master Apr 30, 2021
@stmcallister stmcallister deleted the numloop-fix branch April 30, 2021 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dobs dobs dobs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot unset num_loops for pagerduty_escalation_policy resourse
2 participants
@stmcallister @dobs