Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure start_day_of_week is not specified for a daily schedule restriction #386

Merged

Conversation

drastawi
Copy link
Contributor

This can prevent permanent diffs in cases start day of the week is defined on a daily restriction. This can help in the case that the plugin user has a misconception about what a "daily_restriction" means.

Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for this! 👍

@stmcallister stmcallister merged commit 5c859cc into PagerDuty:master Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants