Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validation to Escalation Policy Teams: MaxItems 1 #412

Merged
merged 1 commit into from
Oct 21, 2021
Merged

Add validation to Escalation Policy Teams: MaxItems 1 #412

merged 1 commit into from
Oct 21, 2021

Conversation

stmcallister
Copy link
Contributor

The PagerDuty API doesn't allow more than one team to be associated with an escalation policy. The provider would run a successful plan but then fail on apply. This change catches that condition during the plan.

Test results:

TF_ACC=1 go test -run "TestAccPagerDutyEscalationPolicy" ./pagerduty -v -timeout 120m
=== RUN   TestAccPagerDutyEscalationPolicy_import
--- PASS: TestAccPagerDutyEscalationPolicy_import (10.53s)
=== RUN   TestAccPagerDutyEscalationPolicy_Basic
--- PASS: TestAccPagerDutyEscalationPolicy_Basic (13.03s)
=== RUN   TestAccPagerDutyEscalationPolicyWithTeams_Basic
--- PASS: TestAccPagerDutyEscalationPolicyWithTeams_Basic (12.50s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	36.604s

@stmcallister stmcallister merged commit 9ecd161 into PagerDuty:master Oct 21, 2021
@stmcallister stmcallister deleted the validate-ep-teams branch October 21, 2021 23:42
@leezen leezen mentioned this pull request Nov 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sjeanpierre Sjeanpierre Sjeanpierre approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stmcallister @Sjeanpierre