-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pagerduty_business_service_subscriber resource #414
Add pagerduty_business_service_subscriber resource #414
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Thank you!! 🎉 🎉
@gsreynolds before we merge this, can you update the reference for the go library?
And then push those changes here? |
2885670
to
5ef2fd0
Compare
Hey @stmcallister, thanks. Rebased against master to resolve merge conflicts. Should be good to go! |
Signed-off-by: Gavin Reynolds <greynolds@pagerduty.com>
Signed-off-by: Gavin Reynolds <greynolds@pagerduty.com>
…ID for business service, subscriber type and subscriber id Signed-off-by: Gavin Reynolds <greynolds@pagerduty.com>
Signed-off-by: Gavin Reynolds <greynolds@pagerduty.com>
5ef2fd0
to
be3515a
Compare
@stmcallister As discussed, I've submitted heimweh/go-pagerduty#73 to additionally check the response body for a successful subscription, as the API will return 200 OK if the result of one (or more) subscriptions in the request was not I've also rebased the branch to catch up with latest changes, but no changes required in this PR other than updating the vendored packages once heimweh/go-pagerduty#73 is merged. Example of 200 OK response body: {
"subscriptions": [
{
"account_id": "PQL6MPB",
"result": "unauthorized",
"subscribable_id": "P3D3U4T",
"subscribable_type": "business_service",
"subscriber_id": "PGW87TJ",
"subscriber_type": "team"
}
]
} Fixes occasional errors resulting from non-success responses. If a non-success response is returned, the resource will retry as normal until retries are exceeded or it is successful.
|
Closes #390