Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Addressing data_source_pagerduty_user paginated lists not finding users after first page #511

Merged
merged 1 commit into from
May 24, 2022
Merged

Addressing data_source_pagerduty_user paginated lists not finding users after first page #511

merged 1 commit into from
May 24, 2022

Conversation

imjaroiswebdev
Copy link
Contributor

Fixes #442

From now on when using Data Sources for querying users that are located after the first 25 registries the data_source_pagerduty_user query will return the expected result.

Tests results:

TF_ACC=1 go test -v -run AccDataSourcePagerDutyUser ./... -timeout 120m
=== RUN   TestAccDataSourcePagerDutyUserContactMethod_Basic
--- PASS: TestAccDataSourcePagerDutyUserContactMethod_Basic (17.43s)
=== RUN   TestAccDataSourcePagerDutyUser_Basic
--- PASS: TestAccDataSourcePagerDutyUser_Basic (14.93s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   32.817s

stmcallister
stmcallister approved these changes May 24, 2022
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks good! thanks @imjaroiswebdev ! 🎉 🌮

@stmcallister stmcallister merged commit fbf2b5c into PagerDuty:master May 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data_source_pagerduty_user does not follow response pagination, failing to find users on later pages.
2 participants
@imjaroiswebdev @stmcallister