Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NaturallyUnitful #480

Closed
mo8it opened this issue Sep 13, 2021 · 4 comments
Closed

NaturallyUnitful #480

mo8it opened this issue Sep 13, 2021 · 4 comments

Comments

@mo8it
Copy link
Contributor

mo8it commented Sep 13, 2021

Please merge NaturallyUnitful or at least mention it :)
@sostock
Copy link
Collaborator

sostock commented Sep 14, 2021

I don’t see a PR related to NaturallyUnitful, so I’m confused as to what should be merged. Of course we can mention it in the README. Someone just needs to make a PR that adds it to the list.

@mo8it mo8it mentioned this issue Sep 14, 2021
Closed
@mo8it
Copy link
Contributor Author

mo8it commented Sep 14, 2021

The pull request is ready. I am waiting for the agreement of the original author of NaturallyUnitful.jl @MasonProtter :)

https://github.com/Mo8it/Unitful.jl/tree/feature/natural_units

@mo8it
Copy link
Contributor Author

mo8it commented Sep 14, 2021

Ready: #481

@sostock sostock mentioned this issue Sep 14, 2021
Closed
@sostock
Copy link
Collaborator

sostock commented Sep 16, 2021

Added to README in #483.

@sostock sostock closed this as completed Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sostock @mo8it