Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #483

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Update README.md #483

merged 1 commit into from
Sep 16, 2021

Conversation

mo8it
Copy link
Contributor

@mo8it mo8it commented Sep 14, 2021

Mentioned NaturallyUnitful.jl

Mentioned NaturallyUnitful.jl
@codecov-commenter
Copy link

Codecov Report

Merging #483 (1183191) into master (492c475) will decrease coverage by 7.87%.
The diff coverage is n/a.

❗ Current head 1183191 differs from pull request most recent head b3f0f9e. Consider uploading reports for the commit b3f0f9e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #483      +/-   ##
==========================================
- Coverage   83.77%   75.90%   -7.88%     
==========================================
  Files          16       16              
  Lines        1344     1129     -215     
==========================================
- Hits         1126      857     -269     
- Misses        218      272      +54     
Impacted Files Coverage Δ
src/types.jl 65.95% <0.00%> (-23.84%) ⬇️
src/utils.jl 74.41% <0.00%> (-20.94%) ⬇️
src/display.jl 75.00% <0.00%> (-20.24%) ⬇️
src/promotion.jl 24.13% <0.00%> (-19.35%) ⬇️
src/complex.jl 83.33% <0.00%> (-16.67%) ⬇️
src/range.jl 75.60% <0.00%> (-14.19%) ⬇️
src/pkgdefaults.jl 7.14% <0.00%> (-11.47%) ⬇️
src/logarithm.jl 61.39% <0.00%> (-8.16%) ⬇️
src/conversion.jl 81.81% <0.00%> (-6.42%) ⬇️
src/units.jl 80.17% <0.00%> (-5.35%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 492c475...b3f0f9e. Read the comment docs.

@sostock
Copy link
Collaborator

sostock commented Sep 14, 2021

At first it seemed weird to me that UnitfulAtomic.jl is under “Units packages” and NaturallyUnitful.jl is under “Feature additions” even though both do similar things. But I guess it is correct since UnitfulAtomic.jl defines its own units and NaturallyUnitful.jl does not.

@sostock sostock merged commit 5f68b2b into PainterQubits:master Sep 16, 2021
@sostock sostock mentioned this pull request Sep 16, 2021
@mo8it mo8it deleted the patch-2 branch December 18, 2021 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants