Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Couple UX improvements #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Couple UX improvements #8

wants to merge 2 commits into from

Commits on Dec 29, 2020

  1. Auto-focus and open soft-keyboard on Android 

    - On iOS the keyboard is displayed automatically when the dialog is shown
- This change makes it work the same way on Android
    @avargaskun
    avargaskun committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    2de1693 View commit details
    Browse the repository at this point in the history

  2. Wait for dialog dismissal before sending result 

    - Do not callback into the Cordova application until dialog is dismissed
- Otherwise, UI elements shown after the callback get dismissed along with the dialog
    @avargaskun
    avargaskun committed Dec 29, 2020
    Configuration menu
    Copy the full SHA
    3ad37ab View commit details
    Browse the repository at this point in the history