Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove connection bar and test for disconnection events #71

Merged
merged 7 commits into from
May 21, 2018
Merged

Remove connection bar and test for disconnection events #71

merged 7 commits into from
May 21, 2018

Conversation

alshakero
Copy link
Collaborator

#69

@alshakero alshakero requested a review from tomalec May 15, 2018 10:05
tomalec
tomalec reviewed May 15, 2018
View reviewed changes
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I'd merge it after we have a custom element as an alternative.

@alshakero alshakero mentioned this pull request May 16, 2018
Merged
@alshakero
Copy link
Collaborator Author

Merging as Palindrom/palindrom-error-catcher#1 is done

tomalec
tomalec reviewed May 21, 2018
View reviewed changes
palindrom-client.html Outdated
@@ -18,99 +18,12 @@

@demo demo/index.html
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, could you remove this demo, as it's no longer applicable

tomalec
tomalec approved these changes May 21, 2018
View reviewed changes
Copy link
Member

@tomalec tomalec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alshakero alshakero merged commit 0335e0f into master May 21, 2018
@alshakero alshakero deleted the Remove-bar branch May 21, 2018 11:16
@alshakero alshakero mentioned this pull request May 24, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomalec tomalec tomalec approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alshakero @tomalec