Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade package typescript from 4.9.5 to 5.4.5 #2016

Closed
palisadoes opened this issue May 27, 2024 · 19 comments
Closed

Upgrade package typescript from 4.9.5 to 5.4.5 #2016

palisadoes opened this issue May 27, 2024 · 19 comments
Assignees
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix

Comments

@palisadoes
Copy link
Contributor

Rationale

  1. This was previously attempted by the automated dependabot job but the PR tests failed.
  2. This issue has been created to fix the issue as there may be multiple dependency requirements that need updating

This is a major revision upgrade and many files may need to be updated to the new syntax, functions, methods and classes

Task

  1. Upgrade package typescript from 4.9.5 to 5.4.5
  2. Remove this package if it is:
    1. unused
    2. unnecessary. For example:
      1. the functionality can be maintained by using another package we are already using,
      2. If we are using only one function or class in the package you can consider replacing it with code that resides in this repository
      3. It is used by a feature that the end user is unlikely to ever use

Background Failing PRs

Release Note Details

Bumps typescript from 4.9.5 to 5.4.5.

Release notes

Sourced from typescript's releases.

TypeScript 5.4.5

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4.3

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

TypeScript 5.4

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

... (truncated)

Commits
  • 27bcd4c Update LKG
  • 9f33bf1 🤖 Pick PR #58098 (Fix constraints of nested homomorph...) into release-5.4 (#...
  • 71b2f84 Bump version to 5.4.5 and LKG
  • 892936f 🤖 Pick PR #58083 (Don't propagate partial union/inter...) into release-5.4 (#...
  • 38a7c05 release-5.4: Always set node-version for setup-node (#58117)
  • b754fc3 🤖 Pick PR #57778 (fix type import check for default-i...) into release-5.4 (#...
  • 8eb3367 Bump version to 5.4.4 and LKG
  • de9096b 🤖 Pick PR #57871 (Divide-and-conquer strategy for int...) into release-5.4 (#...
  • 06aae98 🤖 Pick PR #57973 (Compare package.json paths with cor...) into release-5.4 (#...
  • 6d8134e 🤖 Pick PR #57637 (Fixed a regression related to deter...) into release-5.4 (#...
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
@palisadoes palisadoes added bug Something isn't working security Security fix dependencies Pull requests that update a dependency file labels May 27, 2024
Copy link

github-actions bot commented Jun 7, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Jun 7, 2024
@MadhaneeswaranP
Copy link

Can I take this issue? @palisadoes

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@palisadoes
Copy link
Contributor Author

Unassigning no activity

@github-actions github-actions bot removed the no-issue-activity No issue activity label Jul 26, 2024
@Spoorthy1423
Copy link

Hey!! @palisadoes , i would like to work on this issue, please assign me

@varshith257
Copy link
Member

@Spoorthy1423 You need to get assigned the issue first and submit a PR. Hope you can remind and abide this rule from next time which is one of our community guidelines

Copy link

github-actions bot commented Aug 8, 2024

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Aug 8, 2024
@Cioppolo14
Copy link

Unassigning due to no activity or PR.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Aug 9, 2024
@ManjariRathore
Copy link

Hello @Cioppolo14 @palisadoes
I would like to work on this issue, if possible can you assign this to me. I will raise a draft PR asap.

@Cioppolo14
Copy link

@ManjariRathore you are requesting to work on many issues. You can only be assigned 2 at a time. Please indicate which 2 are your priorities. Thank you.

@VanshikaSabharwal
Copy link

@palisadoes kindly assign me this issue

@VanshikaSabharwal
Copy link

VanshikaSabharwal commented Aug 20, 2024

@varshith257 I have created pull request regarding this issue. Can you please have a look at it. [https://github.com//pull/2207]

@varshith257
Copy link
Member

@VanshikaSabharwal Follow this #2208 (comment)

If you face any difficult reach out me in Slack

@VanshikaSabharwal
Copy link

@VanshikaSabharwal Follow this #2208 (comment)

If you face any difficult reach out me in Slack

okay @varshith257

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@palisadoes
Copy link
Contributor Author

Unassigning. Inactivity

@adithyanotfound
Copy link

Please assign

@adithyanotfound
Copy link

CRA (create-react-app) only supports up to TypeScript version 4.9.5. For better TypeScript compatibility and potential performance benefits, migrating to Vite or preferably Next.js is recommended. If you want me to migrate to Vite please assign Issue #1864.

NOTE: Migrating to Vite may introduce a few issues in deployment that you'll need to address. For now, you could continue using CRA and wait for a future update that supports newer TypeScript versions.

@palisadoes
Copy link
Contributor Author

OK. We are using vite in the API. So there is precedent. We need the consistency.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dependencies Pull requests that update a dependency file security Security fix
Projects
None yet
Development

Successfully merging a pull request may close this issue.

9 participants